Remove DataOwned constraint from into_owned #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful because it allows generalizing `.into_owned()` to `ArrayView` and `ArrayViewMut`. This means that if you want to always clone the elements, you can use `.to_owned()`, while if you want to avoid cloning elements when possible, you can use `.into_owned()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful because it allows generalizing
.into_owned()toArrayViewandArrayViewMut. This means that if you want to always clone the elements, you can use.to_owned(), while if you want to avoid cloning elements when possible, you can use.into_owned().This is technically a breaking change if removing undocumented methods is considered breaking (since
DataOwned::into_ownedno longer exists).