Skip to content

Unify array with shape construction using Shape & ShapeBuilder #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 17, 2016

Conversation

bluss
Copy link
Member

@bluss bluss commented Apr 17, 2016

Now please use these: from_elem, zeros, from_shape_vec, from_shape_vec_unchecked

instead of the following which are deprecated:

  • from_elem_f
  • zeros_f
  • from_vec_dim
  • from_vec_dim_f
  • from_vec_dim_unchecked
  • from_vec_dim_unchecked_f
  • from_vec_dim_stride
  • from_vec_dim_stride_unchecked

Fixes #163

bluss added 8 commits April 17, 2016 17:56
Use these: from_elem, zeros, from_shape_vec, from_shape_vec_unchecked

instead of the following which are deprecated:

+ from_elem_f
+ zeros_f
+ from_vec_dim
+ from_vec_dim_f
+ from_vec_dim_unchecked
+ from_vec_dim_unchecked_f
+ from_vec_dim_stride
+ from_vec_dim_stride_unchecked
@bluss
Copy link
Member Author

bluss commented Apr 17, 2016

cc @daniel-vainsencher

@daniel-vainsencher
Copy link
Contributor

Pretty... :)
On Apr 17, 2016 12:18 PM, "bluss" notifications@github.com wrote:

cc @daniel-vainsencher https://github.com/daniel-vainsencher


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#191 (comment)

@bluss
Copy link
Member Author

bluss commented Apr 17, 2016

That's all we need to hear.. go!

@bluss bluss merged commit a7138e9 into master Apr 17, 2016
@bluss bluss deleted the shapebuilder branch April 17, 2016 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants