Skip to content

Add rustfmt to the CI pipeline #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2019

Conversation

LukeMathWalker
Copy link
Member

This should avoid spurious diffs in PRs due to IDE's settings and/or style nitpicks.

@LukeMathWalker
Copy link
Member Author

It's complaining because it touches code that is not tested, but it's actually fine CI-wise. @jturner314

@jturner314
Copy link
Member

Some of the formatting is a little ugly (primarily unnecessary line breaks in the array! and assert_eq! macro), but it's worth the convenience of being able to just call rustfmt during development without worrying about accidentally reformatting existing code. Thanks!

@jturner314 jturner314 merged commit 07110df into rust-ndarray:master Mar 9, 2019
@LukeMathWalker LukeMathWalker deleted the formatter branch March 10, 2019 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants