Skip to content

Remove skeleton #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2019
Merged

Remove skeleton #833

merged 4 commits into from
Jul 30, 2019

Conversation

skade
Copy link
Contributor

@skade skade commented May 29, 2019

Kills the last 2 mentions of skeleton classes, removes the CSS file.

I went through all pages, but please do so again on review.

@skade skade requested a review from pietroalbini May 29, 2019 18:16
This was referenced May 29, 2019
@pietroalbini
Copy link
Member

Can someone else review this? I'm pretty filled with other stuff right now.

@pietroalbini pietroalbini removed their request for review June 3, 2019 14:15
@Mark-Simulacrum
Copy link
Member

A quick grep for skeleton finds some button-secondary--no-skeleton classes and such in the code which should probably be removed along with skeleton in this PR:

templates/learn/index.hbs
50:{{!-- TODO: Remove button-secondary--no-skeleton once Skeleton is completely removed. --}}
55:             class="button button-secondary button-secondary--no-skeleton mw6-l w-100">{{text learn-doc-std-button}}</a>
63:             class="button button-secondary button-secondary--no-skeleton mw6-l w-100">{{text learn-doc-edition-button}}</a>
71:             class="button button-secondary button-secondary--no-skeleton mw6-l w-100">{{text learn-doc-cargo-button}}</a>
79:             class="button button-secondary button-secondary--no-skeleton mw6-l w-100">{{text learn-doc-rustdoc-button}}</a>
87:             class="button button-secondary button-secondary--no-skeleton mw6-l w-100">{{text learn-doc-rustc-button}}</a>
95:             class="button button-secondary button-secondary--no-skeleton mw6-l w-100">{{text learn-doc-error-button}}</a>
108:               class="button button-secondary button-secondary--no-skeleton mw6-l w-100">
118:               class="button button-secondary button-secondary--no-skeleton mw6-l w-100">
128:               class="button button-secondary button-secondary--no-skeleton mw6-l w-100">

src/styles/app.scss
113:.button.button-secondary--no-skeleton {

@skade
Copy link
Contributor Author

skade commented Jun 3, 2019

@Mark-Simulacrum right, thank you

@skade skade force-pushed the remove-skeleton-css branch from b4e8846 to 436c201 Compare July 29, 2019 18:44
@skade
Copy link
Contributor Author

skade commented Jul 29, 2019

@Mark-Simulacrum It's been a while. Updated.

@Mark-Simulacrum
Copy link
Member

r=me with Skeleton removed from CONTRIBUTING.md as well

@Mark-Simulacrum Mark-Simulacrum self-assigned this Jul 29, 2019
@skade
Copy link
Contributor Author

skade commented Jul 30, 2019

Removed from contributing, merging when checks are green.

@skade skade merged commit 53a4320 into rust-lang:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants