Skip to content

Add back std_detect_env_override #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

sayantn
Copy link
Contributor

@sayantn sayantn commented May 22, 2025

#1776 removed the machinery to manually disable target features at runtime. It was overlooked that this is actually useful for testing, so this pr adds it back (the env_override_no_avx CI run is not added back)

cc @lu-zero

@rustbot
Copy link
Collaborator

rustbot commented May 22, 2025

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@lu-zero
Copy link
Contributor

lu-zero commented May 22, 2025

The machinery only disables, btw :)

@sayantn
Copy link
Contributor Author

sayantn commented May 22, 2025

Oh yes, my mistake. Enabling will be really unsafe

@Amanieu Amanieu added this pull request to the merge queue May 30, 2025
Merged via the queue into rust-lang:master with commit f32b66c May 30, 2025
62 checks passed
@sayantn sayantn deleted the add-back-env-override branch May 31, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants