-
Notifications
You must be signed in to change notification settings - Fork 289
avx512_target_feature
is now stable on nightly
#1802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avx512_target_feature
is now stable on nightly
#1802
Conversation
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
25d712d
to
09592d4
Compare
Just writing up what we found here (yet more reasons to make this a submodule): rust-lang/rust#127013 changed the formatting of
I think the quick fix is to make stdarch have the old formatting behavior, so I implemented some hacks to make that happen. Long-term, hopefully there is a better way to compare the C and rust output? |
09592d4
to
3bc5019
Compare
crates/core_arch/src/macros.rs
Outdated
// the `intrinsic-test` crate compares the output of C and Rust intrinsics. Currently, It uses | ||
// a string representation of the output value to compare. In C, f16 values are currently printed | ||
// as hexadecimal integers. Since https://github.com/rust-lang/rust/pull/127013, rust does print | ||
// them as decimal floating point values. To keep the intrinsics tests working, for now, format | ||
// vectors containing f16 values like C prints them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f16 vector should use the same default formatting as f16. Could you change this to only apply to the Rust output of intrinsic-test instead of all users of the Debug impl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, it takes a bunch more lines but it's probably better this way.
2ff1273
to
4c72851
Compare
and enabling it causes errors on CI