Skip to content

Avx512f avx512vl #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Feb 23, 2021
Merged

Avx512f avx512vl #1010

merged 31 commits into from
Feb 23, 2021

Conversation

minybot
Copy link
Contributor

@minybot minybot commented Feb 17, 2021

cvtepi8_epi64: mm256,mm; cvtepu16_epi32,epi64: mm256,mm; cvtepu32_epi32_epi64, mm256,mm
cvtepu8_epi32,epi64: mm256,mm
cvtpd_epi32,epu32: mm256,mm
cvtpd_ps: mm256,mm
cvtps_epi32,epu32,ph: mm256,mm;
cvtsepi32_epi8,epi16: mm256,mm
cvtsepi32_mask_storeu_epi16,epi8: mm256,mm
cvtsepi64_epi16,epi32: mm256,mm
cvtsepi64_mask_storeu_epi8,epi16,epi32: mm256,mm
cvtusepi32_epi8,epi16: mm256,mm
cvtusepi32_mask_storeu_epi8,epi16: mm256, mm
cvtusepi64_epi8,epi16,epi32: mm256,mm
cvtusepi64_mask_storeu_epi8,epi16,epi32: mm256,mm
cvtsi512_si32
cvttpd_epi32,epu32: mm256,mm; cvttps_epi32,epu32: mm256,mm
mm_cvt_roundi64_ss,sd

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@minybot
Copy link
Contributor Author

minybot commented Feb 18, 2021

Same issue, osX github CI

---- core_arch::x86::abm::assert__lzcnt_u32_lzcnt stdout ----
exit code: 1
LLVM ERROR: out of memory
fatal error: /Applications/Xcode_12.3.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/otool: fatal error in /Applications/Xcode_12.3.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/otool-classic

@minybot
Copy link
Contributor Author

minybot commented Feb 19, 2021

It seems i686-unknown-linux-gnu github CI has some problems?

@minybot
Copy link
Contributor Author

minybot commented Feb 20, 2021

stdarch-test bugs?

Compiling stdarch-test v0.1.0 (/checkout/crates/stdarch-test)
LLVM ERROR: Do not know how to expand the result of this operator!
error: could not compile core_arch

@Amanieu
Copy link
Member

Amanieu commented Feb 20, 2021

_mm_cvt_roundi64_ss and _mm_cvt_roundsi64_ss are only available on x86_64, not x86.

@Amanieu
Copy link
Member

Amanieu commented Feb 20, 2021

Check against the Clang headers to see which intrinsics are wrapped in #ifdef __x86_64__.

@minybot
Copy link
Contributor Author

minybot commented Feb 20, 2021

Check against the Clang headers to see which intrinsics are wrapped in #ifdef __x86_64__.

Thanks. Before we put "epi64" and "pd" tests on x86_64. Should we move those back to x86?

@Amanieu
Copy link
Member

Amanieu commented Feb 23, 2021

The tests for intrinsics defined in x86 should be in x86, and the tests for intrinsics defined in x86_64 should be in x86_64. That way x86_64 runs tests in both x86 and x86_64.

@Amanieu
Copy link
Member

Amanieu commented Feb 23, 2021

Considering how large these files are already, maybe you should split the tests off into a separate file.

@minybot
Copy link
Contributor Author

minybot commented Feb 23, 2021

Considering how large these files are already, maybe you should split the tests off into a separate file.

Yes, but all test will be around 20000 lines.
The intrinsic for avx512f is still around 40000 lines.
Do you think which one is better? (one 60000 lines file or two 40000 and 20000 line files)

@Amanieu
Copy link
Member

Amanieu commented Feb 23, 2021

I guess it doesn't really make a difference.

@Amanieu Amanieu merged commit 216009f into rust-lang:master Feb 23, 2021
@minybot minybot deleted the avx512f_avx512vl branch February 25, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants