Skip to content

Fixes from Linkcheck #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/code-considerations/breaking-changes/fundamental.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Type annotated with the `#[fundamental]` attribute have different coherence rule
- `Box<T>`
- `Pin<T>`

Typically, the scope of [breakage in new trait impls](./reviewing-code/breakage/new-trait-impls.md) is limited to inference and deref-coercion. New trait impls on `#[fundamental]` types may overlap with downstream impls and cause other kinds of breakage.
Typically, the scope of [breakage in new trait impls](./new-trait-impls.md) is limited to inference and deref-coercion. New trait impls on `#[fundamental]` types may overlap with downstream impls and cause other kinds of breakage.

[RFC 1023]: https://rust-lang.github.io/rfcs/1023-rebalancing-coherence.html

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ let b = Arc::from("a");

will no longer compile, because we've previously been relying on inference to figure out the `T` in `Box<T>`.

This kind of breakage can be ok, but a [crater] run should estimate the scope.
This kind of breakage can be ok, but a [crater](../../tools-and-bots/crater.md) run should estimate the scope.

## Deref coercion breaks when a new impl is introduced

Expand Down