Add a SockAddr type #2
Conversation
We don't want to be stuck only supporting IP sockets
| return None; | ||
| } | ||
|
|
||
| Some(mem::transmute_copy(&self.storage)) |
There was a problem hiding this comment.
One day this may bite us, but let's hope it's way far away!
There was a problem hiding this comment.
I was somewhat terrified when I saw that this was how the addr2raw function was implemented as well, but it works.
|
|
||
| /// Returns this address as a `SocketAddrV4` if it is in the `AF_INET` | ||
| /// family. | ||
| pub fn as_inet(&self) -> Option<SocketAddrV4> { |
There was a problem hiding this comment.
Perhaps this could return &SocketAddrV4 instead? (a relatively large struct to copy as we go down)
There was a problem hiding this comment.
That will lock us into guaranteeing that SocketAddrV4 has the same representation as sockaddr_in, but if that's okay then sure.
There was a problem hiding this comment.
Oh wait good point, let's not do that.
| impl From<SocketAddrV4> for SockAddr { | ||
| fn from(addr: SocketAddrV4) -> SockAddr { | ||
| unsafe { | ||
| SockAddr::from_raw_parts(&addr as *const _ as *const _, |
There was a problem hiding this comment.
Could this throw in some assert_eq! about the size of SocketAddrV4? (same for v6 below)
There was a problem hiding this comment.
Done via transmute to check statically.
|
|
|
Ok, let's stick with it as-is and fix up ergonomics as we see fit. Thanks again! (if you'd like a publish of this just lemme know) |
|
Er actually, added you as collaborator + crate owner, feel free to publish if you need it! (just don't forget to bump the version) |
|
Thanks! |
We don't want to be stuck only supporting IP sockets