-
Notifications
You must be signed in to change notification settings - Fork 78
Updating readme instructions #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating readme instructions #489
Conversation
Issue number #252 |
Readme.md
Outdated
To check if all is working correctly, run ``./y.sh cargo build --manifest-path tests/hello-world/Cargo.toml`` in your terminal. | ||
|
||
|
||
### Install rustup if need it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this information should be at the top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But first we have to run the prepare and build commands as i understand. That is the reason that is not on top of that section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Euh... You need to rust to build any y.sh
command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you say at the top, which section do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before Building
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Euh... You need to rust to build any
y.sh
command.
Sorry, at the begining I understood something different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's a nice improvement.
Waiting to see what @GuillaumeGomez says for the ./y.sh prepare
stuff.
Readme.md
Outdated
|
||
```bash | ||
export CG_GCCJIT_DIR=[the full path to rustc_codegen_gcc] | ||
$ ./y.sh prepare | ||
$ ./y.sh build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I missed that. There was an update in my fork that I just synced and this now needs to be:
$ ./y.sh build | |
$ ./y.sh build --sysroot |
Thanks for your contribution! |
It's a pleasure :) |
Updating some sections inside of the readme to make it easier to follow.