Skip to content

Updating readme instructions #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 17, 2024

Conversation

Gerson2102
Copy link
Contributor

Updating some sections inside of the readme to make it easier to follow.

@Gerson2102
Copy link
Contributor Author

Issue number #252

Readme.md Outdated
To check if all is working correctly, run ``./y.sh cargo build --manifest-path tests/hello-world/Cargo.toml`` in your terminal.


### Install rustup if need it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this information should be at the top.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But first we have to run the prepare and build commands as i understand. That is the reason that is not on top of that section.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Euh... You need to rust to build any y.sh command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you say at the top, which section do you mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before Building.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Euh... You need to rust to build any y.sh command.

Sorry, at the begining I understood something different.

Copy link
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a nice improvement.

Waiting to see what @GuillaumeGomez says for the ./y.sh prepare stuff.

Readme.md Outdated

```bash
export CG_GCCJIT_DIR=[the full path to rustc_codegen_gcc]
$ ./y.sh prepare
$ ./y.sh build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I missed that. There was an update in my fork that I just synced and this now needs to be:

Suggested change
$ ./y.sh build
$ ./y.sh build --sysroot

@antoyo antoyo merged commit 6e5395a into rust-lang:master Apr 17, 2024
@antoyo
Copy link
Contributor

antoyo commented Apr 17, 2024

Thanks for your contribution!

@Gerson2102
Copy link
Contributor Author

Thanks for your contribution!

It's a pleasure :)

@Gerson2102 Gerson2102 deleted the updating-readme-instructions branch April 17, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants