Skip to content

rustc invocation standarized #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

igaray
Copy link
Member

@igaray igaray commented Dec 27, 2020

[Fixes #614]

As mentioned in #614, rustc is invoked in different ways throughout the book, although there were not that many fixable instances.
I ripgrep'd for rustc\ and fixed the ones I found.

Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minus the two small things I already posted!

@camelid
Copy link
Member

camelid commented Dec 27, 2020

By the way, you should take Fixes #614 out of the title and put it in the body. GitHub won't link the issue to the PR otherwise, and having Fixes #NNN in the title can cause glitches.

@igaray igaray changed the title [Fixes #614] rustc invocation standarized rustc invocation standarized Dec 27, 2020
@jyn514
Copy link
Member

jyn514 commented Dec 28, 2020

@igaray is this ready to go? It looks good to me :)

@igaray igaray marked this pull request as ready for review December 28, 2020 20:36
@igaray
Copy link
Member Author

igaray commented Dec 28, 2020

Ready to go!

@LeSeulArtichaut LeSeulArtichaut merged commit 320df68 into rust-lang:master Dec 28, 2020
@igaray igaray deleted the 614.make_consistent_use_of_development_rustc_invokations branch December 29, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a consistent use of development rustc invocations
4 participants