add string interning wikipedia link #960
Conversation
src/overview.md
Outdated
| string interning is a method of storing only one copy of each distinct | ||
| string value, which must be immutable. | ||
| [read more](https://en.wikipedia.org/wiki/String_interning) |
There was a problem hiding this comment.
| string interning is a method of storing only one copy of each distinct | |
| string value, which must be immutable. | |
| [read more](https://en.wikipedia.org/wiki/String_interning) | |
| [String interning] is a way of storing only one immutable copy of each distinct string value. |
and then add a reference link at the bottom:
[String interning]: https://en.wikipedia.org/wiki/String_interning)
There was a problem hiding this comment.
You didn't add the reference at the bottom. It should go near the other links.
There was a problem hiding this comment.
you mean add [String interning]: https://en.wikipedia.org/wiki/String_interning) under read more?
There was a problem hiding this comment.
Please put it with the other links for the paragraph: see lines 101-115
There was a problem hiding this comment.
You undid the previous changes when you added the link.
There was a problem hiding this comment.
yeah but now that change is back
There was a problem hiding this comment.
I mean this change: https://github.com/rust-lang/rustc-dev-guide/pull/960/files#r523762736
It's disappeared.
There was a problem hiding this comment.
Can you please only show 'string interning' once instead of twice? Right now there are 5 lines related to it, I would rather have 1 line like it was before. Or in other words, my suggestion should replace the first change, not add to it.
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
No description provided.