Skip to content

Fix links for cranelift #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

Fix links for cranelift #809

merged 1 commit into from
Jul 22, 2020

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Jul 22, 2020 •
edited
Loading

The wasmtime renamed their default branch to main thus its link returns 404 now.
This replaces master with HEAD which is an alias for the default branch on GitHub, not main, just in case.

LeSeulArtichaut
LeSeulArtichaut approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. CI failure seems spurious, I re-ran the checks.

@JohnTitor
Copy link
Member Author

JohnTitor commented Jul 22, 2020 •
edited
Loading

I re-ran the checks.

Thanks! It's now green, merging.

@JohnTitor JohnTitor merged commit aecb593 into rust-lang:master Jul 22, 2020
@JohnTitor JohnTitor deleted the cranelift branch July 22, 2020 10:32
JohnTitor added a commit to shepmaster/rustc-dev-guide that referenced this pull request Jul 28, 2020
@JohnTitor
Fix links for cranelift (rust-lang#809)
1474f1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeSeulArtichaut LeSeulArtichaut LeSeulArtichaut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnTitor @LeSeulArtichaut