Skip to content

update conventions #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2020
Merged

update conventions #735

merged 2 commits into from
Jun 5, 2020

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Jun 5, 2020

Not sure about the exact wording yet.

@lcnr
Copy link
Contributor Author

lcnr commented Jun 5, 2020 

     ┌── appendix/background.md:145:3 ───

     │

 145 │ - [Compilers: Principles, Techniques, and Tools, 2nd Edition](https://www.amazon.com/dp/9332518661/ref=cm_sw_r_other_apa_1tUSBb5VHAVA1)

     │   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Server responded with 503 Service Unavailable

spastorino
spastorino reviewed Jun 5, 2020
View reviewed changes
mark-i-m
mark-i-m reviewed Jun 5, 2020
View reviewed changes
src/conventions.md
nearby code you are already changing for other purposes are also ok.
**Format liberally.** While only the final commit of a PR must be correctly
formatted, it is both easier to review and less noisy to format each commit
individually using `./x.py fmt`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:+10000:

@mark-i-m
Copy link
Member

mark-i-m commented Jun 5, 2020

@lcnr when you fix Santiago's comment, could you also rebase over master?

lcnr and others added 2 commits June 5, 2020 17:46
@lcnr
update conventions
667c475
@lcnr @spastorino
typo
b6959a0 
Co-authored-by: Santiago Pastorino <spastorino@gmail.com>
@lcnr
Copy link
Contributor Author

lcnr commented Jun 5, 2020

Done. RFM I guess

@spastorino spastorino merged commit 8a9a1f9 into rust-lang:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-i-m mark-i-m mark-i-m left review comments

@spastorino spastorino spastorino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcnr @mark-i-m @spastorino