Skip to content

Add documentation of UI test error annotation message substring support #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2020
Merged

Add documentation of UI test error annotation message substring support #725

merged 2 commits into from
May 29, 2020

Conversation

chrissimpkins
Copy link
Member

This adds a useful tip from @mark-i-m about UI test error annotation message substring support to address tidy line length requirements.

Associated #724

JohnTitor
JohnTitor approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's ask @mark-i-m to check the wording as well, just in case :)

@chrissimpkins @JohnTitor
Update src/tests/adding.md
efe6e79 
Co-authored-by: Yuki Okushi <huyuumi.dev@gmail.com>
mark-i-m
mark-i-m approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mark-i-m mark-i-m merged commit c9850bb into rust-lang:master May 29, 2020
@chrissimpkins chrissimpkins deleted the error-annotations-ui-tests branch May 29, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-i-m mark-i-m mark-i-m approved these changes

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrissimpkins @mark-i-m @JohnTitor