Skip to content

Add Karrq's salsa chapter #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2019
Merged

Add Karrq's salsa chapter #529

merged 2 commits into from
Nov 27, 2019

Conversation

mark-i-m
Copy link
Member

Closes #401

cc @Karrq (who gets all credit for this content)

This great content, but Karrq doesn't seem to have time ATM and the PR has been open for too long.

@mark-i-m
Copy link
Member Author

Also, it appears the backing branch was deleted or something in the other PR?

@mark-i-m
Copy link
Member Author

cc @spastorino who approved the original

@Karrq
Copy link

Karrq commented Nov 27, 2019

Yes I'm sorry I was planning to reply to the issue but alas I got stormed with other things.

I wanted to let you know that I couldn't work on this anymore... Sorry.

And yes I deleted the fork accidentally. Github doesn't really warn you about open pull requests when you do that...

@spastorino spastorino merged commit 9e8af60 into rust-lang:master Nov 27, 2019
mark-i-m added a commit to spastorino/rustc-dev-guide that referenced this pull request Jan 2, 2020
* add Karrq's salsa chapter

* add youtu.be short url
@mark-i-m mark-i-m deleted the salsa branch March 7, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants