Simplify long sentence #2443
Merged
Simplify long sentence #2443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
tshepang
reviewed
Jun 2, 2025
src/coroutine-closures.md
Outdated
| @@ -10,7 +10,9 @@ As a consequence of the code being somewhat general, this document may flip betw | |||
|
|
|||
| ## HIR | |||
|
|
|||
| Async closures (and in the future, other coroutine flavors such as `gen`) are represented in HIR as a `hir::Closure` whose closure-kind is `ClosureKind::CoroutineClosure(_)`[^k1], which wraps an async block, which is also represented in HIR as a `hir::Closure`) and whose closure-kind is `ClosureKind::Closure(CoroutineKind::Desugared(_, CoroutineSource::Closure))`[^k2]. | |||
| Async closures (and in the future, other coroutine flavors such as `gen`) are represented in HIR as a `hir::Closure`. | |||
| Its closure-kind is `ClosureKind::CoroutineClosure(_)`[^k1], which wraps an async block, which is also represented in HIR as a `hir::Closure`. | |||
There was a problem hiding this comment.
"its" can be thought to refer to "Async closures"
Suggested change
| Its closure-kind is `ClosureKind::CoroutineClosure(_)`[^k1], which wraps an async block, which is also represented in HIR as a `hir::Closure`. | |
| The closure-kind of the `hir::Closure` is `ClosureKind::CoroutineClosure(_)`[^k1], which wraps an async block, which is also represented in HIR as a `hir::Closure`. |
There was a problem hiding this comment.
Sorry, but I am going to gently push back on this one: I don't think "its" can be thought to refer to "Async closures", because of the plurality of "Async closures". Only "their" can be used where I've written "its", which makes the "its" unambiguous.
There was a problem hiding this comment.
I see... that it tripped me indicates that the text here is not so simple. My suggestion removes an ambiguity, even if repetitive.
There was a problem hiding this comment.
Yeah, even as I was writing my objection that came to mind 😅
I applied your suggestion. Thanks for the review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.