Skip to content

[perf experiment] Revert "Rollup merge of #99342 - TaKO8Ki:avoid-symbol-to-string-conve… #99369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

matthiaskrgr
Copy link
Member

…rsions, r=compiler-errors"

This reverts commit 6277ac2, reversing
changes made to 0c6e01b.

r? @ghost

…ing-conversions, r=compiler-errors"

This reverts commit 6277ac2, reversing
changes made to 0c6e01b.
@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in need_type_info.rs

cc @lcnr

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 17, 2022
@matthiaskrgr
Copy link
Member Author

@bors try rust-timer queue

@matthiaskrgr
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 17, 2022
@bors
Copy link
Collaborator

bors commented Jul 17, 2022

⌛ Trying commit 6537d39 with merge f5b5768a77119ca3933b67223782ef7a3b238bb1...

@bors
Copy link
Collaborator

bors commented Jul 17, 2022

☀️ Try build successful - checks-actions
Build commit: f5b5768a77119ca3933b67223782ef7a3b238bb1 (f5b5768a77119ca3933b67223782ef7a3b238bb1)

@rust-timer
Copy link
Collaborator

Queued f5b5768a77119ca3933b67223782ef7a3b238bb1 with parent 1cd72b7, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f5b5768a77119ca3933b67223782ef7a3b238bb1): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
2.3% 3.0% 6
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
-2.0% -2.0% 1
Improvements 🎉
(secondary)
-2.8% -4.1% 9
All 😿🎉 (primary) -2.0% -2.0% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

@rustbot rustbot added perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 17, 2022
@matthiaskrgr matthiaskrgr deleted the rev_sym2string branch January 25, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants