-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Types with reachable constructors are reachable #97096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
// edition:2021 | ||
//! Missing docs lint warns about undocumented exported items. | ||
//! Use the lint to additionally verify that items are reachable | ||
//! but not exported. | ||
#![allow(non_camel_case_types)] | ||
#![deny(missing_docs)] | ||
|
||
mod hidden { | ||
pub struct s; | ||
pub enum e { x, y, z } | ||
pub use e::*; | ||
impl s { | ||
pub fn f(&self) {} | ||
} | ||
impl e { | ||
pub fn g(&self) {} | ||
} | ||
} | ||
// Hide all type definitions while reexporting their constructors: | ||
mod e {} | ||
mod x {} | ||
mod y {} | ||
mod z {} | ||
mod s {} | ||
pub use hidden::*; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// Verify that a type is considered reachable when its constructor is | ||
// reachable. The auxiliary library is constructed so that all types are | ||
// shadowed and cannot be named directly, while their constructors are | ||
// reexported. Regression test for issue #96934. | ||
// | ||
// aux-build:ctor_aux.rs | ||
// edition:2021 | ||
// build-pass | ||
|
||
extern crate ctor_aux; | ||
|
||
fn main() { | ||
ctor_aux::s.f(); | ||
ctor_aux::x.g(); | ||
ctor_aux::y.g(); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.