Stop using newtypes in rt::io::buffered #9156
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for rust-lang#9155. Currently, any uses of BufferedStream outside of libstd ICE.
bors
added a commit
that referenced
this pull request
Sep 14, 2013
This is a workaround for #9155. Currently, any uses of BufferedStream outside of libstd ICE.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 18, 2022
fix [`manual_flatten`] help texts order fixes rust-lang#8948 Whenever suggestion for this lint does not fit in one line, legacy solution has some unexpected/unhandled behavior: lint will then generate two help messages which seem to be shown in the wrong order. The second help message in that case will contain the suggestion. The first help message always refers to a suggestion message, and **it should adapt** depending on the location of the suggestion: - inline suggestion within the error/warning message - suggestion separated into a second help text This is my first contribution here, so I hope I didn't miss anything for creating this PR. changelog: fix [`manual_flatten`] help texts order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for #9155. Currently, any uses of BufferedStream
outside of libstd ICE.