Fix Acceptor Iterator #9089
Closed
Fix Acceptor Iterator #9089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Sep 9, 2013
The iterator over incoming connections has no natural end, so it should always return Some(_). Currently, if an incoming connection fails, the iterator returns None. Trying to accept another connection afterwards enters the realm of undefined behavior (due to the iterator protocol being silent on the issue). This PR changes wraps the underlying accept call in Some, so the iterator never finishes.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 18, 2022
Fix ICE in `dereference.rs` fixes rust-lang#9089 changelog: Fix ICE when dereferencing or borrowing on explicit returns from closures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iterator over incoming connections has no natural end, so it should always return Some(_).
Currently, if an incoming connection fails, the iterator returns None.
Trying to accept another connection afterwards enters the realm of undefined behavior (due to the iterator protocol being silent on the issue).
This PR changes wraps the underlying accept call in Some, so the iterator never finishes.