Generate random BigUints and BigInts #9007
Conversation
|
Looks pretty good, but could this just be a single trait: |
| /// Generate a random BigUint of the given bit size. | ||
| fn gen_bigint(&mut self, bit_size: uint) -> BigInt { | ||
| let biguint = self.gen_biguint(bit_size); | ||
| let sign = if biguint.is_zero() { Zero } |
There was a problem hiding this comment.
I believe this means that the probability of zero is double that of any other number; it would be good to make sure that it is actually uniform.
|
Well it could be implemented as a single trait, but is there a reason to? Everything else about the two types is so nicely segregated that they could be moved into separate modules. It seems more consistent to me to maintain the split. |
- use identifiers with underscores to avoid unused variable warning - implement on R: Rng instead of on R: RngUtil - bugfix: zero BigInts were being generated twice as often as any other number - test that gen_biguint(0) always returns zero
|
fwiw, I'm in favor of the traits getting merged. I'm also generally not a fan of having lots and lots of traits, but that's more of just a general guideline that I try to follow. In this specific case I don't think that it really makes a lot of sense to have one trait per type when it actually fits pretty well to encompass both types at the same time. Things may be separate now between Uint and Int, but I'm always a fan of unifying if possible for clarity and reduction of surface area. Just my opinions though :) |
Rustup r? `@ghost` changelog: none
No description provided.