Enable "generate-link-to-definition" option on rust tools docs as well #89217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
T-rustdoc
rust-highfive
added
the
S-waiting-on-review
|
@GuillaumeGomez why did you cc the whole team? @bors r+ rollup |
|
📌 Commit 9fa59e1 has been approved by |
bors
added
S-waiting-on-bors
jyn514
added
T-bootstrap
|
To keep everyone up-to-date. I think it's an important change after all. |
7 tasks
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 24, 2021
…-rust-tools, r=jyn514 Enable "generate-link-to-definition" option on rust tools docs as well Just realized that we enable the option for the compiler crates, but we don't have it for rustdoc and the other tools documentation... Part of rust-lang#89095. cc `@rust-lang/rustdoc` r? `@Mark-Simulacrum`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2021
…ingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#88893 (Add 1.56.0 release notes) - rust-lang#89001 (Be explicit about using Binder::dummy) - rust-lang#89072 (Avoid a couple of Symbol::as_str calls in cg_llvm ) - rust-lang#89104 (Simplify scoped_thread) - rust-lang#89208 ([rfc 2229] Drop fully captured upvars in the same order as the regular drop code) - rust-lang#89210 (Add missing time complexities to linked_list.rs) - rust-lang#89217 (Enable "generate-link-to-definition" option on rust tools docs as well) - rust-lang#89221 (Give better error for `macro_rules! name!`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just realized that we enable the option for the compiler crates, but we don't have it for rustdoc and the other tools documentation...
Part of #89095.
cc @rust-lang/rustdoc
r? @Mark-Simulacrum