drop some redundant Ord method implementations #8862
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think you can drop the ones for |
|
Unless I'm reading it wrong, |
Ratio is generic and so might contain a non-total orderable type. It should not use the default Ord implementation.
|
I guess the current implementation is incorrect then. |
|
It's possible that JSON shouldn't be allowing |
bors
added a commit
that referenced
this pull request
Aug 31, 2013
If this were to break something, I would expect existing tests to catch it, and a `make check` run passes locally.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 4, 2022
…xFrednet `get_last_with_len`: lint `VecDeque` and any deref to slice changelog: [`get_last_with_len`]: lint `VecDeque` and any deref to slice Previously only `Vec`s were linted, this will now catch any usages on slices, arrays, etc. It also suggests `.back()` for `VecDeque`s Also moves the lint into `methods/`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this were to break something, I would expect existing tests to catch it, and a
make checkrun passes locally.