Add RngUtils::sample() method for reservoir sampling from iterators #8491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think returning the sampling array is fine since the algorithm is more or less defined in terms of such an array. It has to exist, might as well return it. As for whether to put this on Thanks so much! |
bors
added a commit
that referenced
this pull request
Aug 15, 2013
…aydon Fixes #7722 I had a couple of queries: - Should this return an array or an iterator? - Should this be a method on iterators or on the rng? I implemented it in RngUtils as it seemed to belong with shuffle().
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 14, 2022
tests: use std::thread::available_parallelism() instead of num_cpus to get thread count removes the dependency added in rust-lang/rust-clippy#8451 --- *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: tests: use std::thread::available_parallelism() instead of num_cpus to get thread count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7722
I had a couple of queries: