Skip to content

rustc_codegen_ssa: turn builders "unpositioned" after emitting a terminator. #84771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

rustc_codegen_ssa: turn builders "unpositioned" after emitting a terminator. #84771

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2523a29
rustc_codegen_ssa: use a different type for "unpositioned" builders.
eddyb Apr 29, 2021
a297a5b
rustc_codegen_ssa: take the handlers directly in `catch_switch`.
eddyb Apr 30, 2021
0b37b58
rustc_codegen_ssa: take the `&FnAbi` directly in `call`/`invoke`, for…
eddyb Apr 30, 2021
58402a9
rustc_codegen_llvm: don't require a builder to call `add_incoming_to_…
eddyb Apr 30, 2021
ce953ec
rustc_codegen_ssa: pass the builder through `codegen_intrinsic_call` …
eddyb Apr 30, 2021
78e2ac0
rustc_codegen_ssa: turn builders "unpositioned" after emitting a term…
eddyb Apr 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions compiler/rustc_codegen_llvm/src/abi.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,11 +601,7 @@ impl<'tcx> FnAbiLlvmExt<'tcx> for FnAbi<'tcx, Ty<'tcx>> {
}
}

impl AbiBuilderMethods<'tcx> for Builder<'a, 'll, 'tcx> {
fn apply_attrs_callsite(&mut self, fn_abi: &FnAbi<'tcx, Ty<'tcx>>, callsite: Self::Value) {
fn_abi.apply_attrs_callsite(self, callsite)
}

impl AbiBuilderMethods for Builder<'_, '_, '_> {
fn get_param(&self, index: usize) -> Self::Value {
llvm::get_param(self.llfn(), index as c_uint)
}
Expand Down
2 changes: 1 addition & 1 deletion compiler/rustc_codegen_llvm/src/asm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ fn inline_asm_call(
alignstack,
llvm::AsmDialect::from_generic(dia),
);
let call = bx.call(v, inputs, None);
let call = bx.call(v, inputs, None, None);

// Store mark in a metadata node so we can map LLVM errors
// back to source locations. See #17552.
Expand Down
Loading