Skip to content

Added default impls for container methods #8036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sfackler
Copy link
Member

A couple of implementations of Container::is_empty weren't exactly
self.len() == 0 so I left them alone (e.g. Treemap).

@sfackler
Copy link
Member Author

Looks like a trie test fails. I'm looking into it.

@thestinger
Copy link
Contributor

It's possible that there are still default method bugs blocking this.

@sfackler
Copy link
Member Author

Looks like there are still some bugs:

rust: task failed at 'assertion failed: `(left == right) && (right == left)` (left: `1`, right: `0`)', /Users/sfackler/Documents/no_scan/code/rust/src/libstd/trie.rs:456
rust: task failed at 'explicit failure', /Users/sfackler/Documents/no_scan/code/rust/src/libstd/task/mod.rs:747
rust: task failed at 'assertion failed: `(left == right) && (right == left)` (left: `Some(4302215072)`, right: `Some(2)`)', /Users/sfackler/Documents/no_scan/code/rust/src/libstd/trie.rs:529
test str::tests::test_trim_left_chars ... ok

Program received signal EXC_BAD_ACCESS, Could not access memory.
Reason: KERN_INVALID_ADDRESS at address: 0x000000000000000a
[Switching to process 32918 thread 0x20b]
0x00000001001fe714 in trie..TrieNode$LT$uint$GT$::_a48e69e59d886de1::glue_drop_39521 ()
(gdb)

@msullivan mentioned that he's making a new snapshot for the default method fixes, so maybe that'll help?

A couple of implementations of Container::is_empty weren't exactly
self.len() == 0 so I left them alone (e.g. Treemap).
@sfackler
Copy link
Member Author

It seems to be working fine after a rebase. I may have not had @msullivan's fix last time.

@bluss
Copy link
Member

bluss commented Jul 26, 2013

If it depends on sully's fix, then you may have to wait after a snapshot?

@huonw
Copy link
Member

huonw commented Jul 26, 2013

(There's a snapshot with those fixes in the queue: #8050)

@sfackler
Copy link
Member Author

It seems to be working fine on the current snapshot after rebasing.

bors added a commit that referenced this pull request Jul 27, 2013
A couple of implementations of Container::is_empty weren't exactly
self.len() == 0 so I left them alone (e.g. Treemap).
@bors bors closed this Jul 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants