Skip to content

Extend meta parameters to all generated code in compat_fn. #79205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2020
Merged

Extend meta parameters to all generated code in compat_fn. #79205

merged 1 commit into from
Nov 20, 2020

Conversation

jdm
Copy link
Contributor

@jdm jdm commented Nov 19, 2020

Fixes #79203. This addresses a regression from 7e20323 for UWP targets.

@rust-highfive
Copy link
Contributor

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2020
@m-ou-se
Copy link
Member

m-ou-se commented Nov 20, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 20, 2020

📌 Commit 24bbca4 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2020
@m-ou-se m-ou-se assigned m-ou-se and unassigned joshtriplett Nov 20, 2020
@m-ou-se m-ou-se added O-windows Operating system: Windows T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 20, 2020
@bors
Copy link
Collaborator

bors commented Nov 20, 2020

⌛ Testing commit 24bbca4 with merge c9c57fa...

@bors
Copy link
Collaborator

bors commented Nov 20, 2020

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing c9c57fa to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 20, 2020
@bors bors merged commit c9c57fa into master Nov 20, 2020
@rustbot rustbot added this to the 1.50.0 milestone Nov 20, 2020
@camelid camelid deleted the jdm-patch-1 branch November 23, 2020 02:11
@SimonSapin SimonSapin mentioned this pull request Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
merged-by-bors This PR was explicitly merged by bors. O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.

UWP standard library no longer builds
6 participants
@jdm @rust-highfive @m-ou-se @bors @joshtriplett @rustbot