-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Rustdoc check option #78984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rustdoc check option #78984
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// compile-flags: -Z unstable-options --check | ||
|
||
#![deny(missing_docs)] | ||
#![deny(rustdoc)] | ||
|
||
//! ```rust,testharness | ||
//~^ ERROR | ||
//! let x = 12; | ||
//! ``` | ||
|
||
pub fn foo() {} | ||
//~^ ERROR | ||
//~^^ ERROR | ||
|
||
/// hello | ||
//~^ ERROR | ||
/// | ||
/// ```rust,testharness | ||
/// let x = 12; | ||
/// ``` | ||
pub fn bar() {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
error: missing documentation for a function | ||
--> $DIR/check-fail.rs:11:1 | ||
| | ||
LL | pub fn foo() {} | ||
| ^^^^^^^^^^^^ | ||
| | ||
note: the lint level is defined here | ||
--> $DIR/check-fail.rs:3:9 | ||
| | ||
LL | #![deny(missing_docs)] | ||
| ^^^^^^^^^^^^ | ||
|
||
error: missing code example in this documentation | ||
--> $DIR/check-fail.rs:11:1 | ||
| | ||
LL | pub fn foo() {} | ||
| ^^^^^^^^^^^^^^^ | ||
| | ||
note: the lint level is defined here | ||
--> $DIR/check-fail.rs:4:9 | ||
| | ||
LL | #![deny(rustdoc)] | ||
| ^^^^^^^ | ||
= note: `#[deny(missing_doc_code_examples)]` implied by `#[deny(rustdoc)]` | ||
|
||
error: unknown attribute `testharness`. Did you mean `test_harness`? | ||
--> $DIR/check-fail.rs:6:1 | ||
| | ||
LL | / //! ```rust,testharness | ||
LL | | | ||
LL | | //! let x = 12; | ||
LL | | //! ``` | ||
| |_______^ | ||
| | ||
note: the lint level is defined here | ||
--> $DIR/check-fail.rs:4:9 | ||
| | ||
LL | #![deny(rustdoc)] | ||
| ^^^^^^^ | ||
= note: `#[deny(invalid_codeblock_attributes)]` implied by `#[deny(rustdoc)]` | ||
= help: the code block will either not be tested if not marked as a rust one or the code will be wrapped inside a main function | ||
|
||
error: unknown attribute `testharness`. Did you mean `test_harness`? | ||
--> $DIR/check-fail.rs:15:1 | ||
| | ||
LL | / /// hello | ||
LL | | | ||
LL | | /// | ||
LL | | /// ```rust,testharness | ||
LL | | /// let x = 12; | ||
LL | | /// ``` | ||
| |_______^ | ||
| | ||
= help: the code block will either not be tested if not marked as a rust one or the code will be wrapped inside a main function | ||
|
||
error: aborting due to 4 previous errors | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// check-pass | ||
// compile-flags: -Z unstable-options --check | ||
|
||
#![warn(missing_docs)] | ||
//~^ WARN | ||
//~^^ WARN | ||
#![warn(rustdoc)] | ||
|
||
pub fn foo() {} | ||
//~^ WARN | ||
//~^^ WARN |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
warning: missing documentation for the crate | ||
--> $DIR/check.rs:4:1 | ||
| | ||
LL | / #![warn(missing_docs)] | ||
LL | | | ||
LL | | | ||
LL | | #![warn(rustdoc)] | ||
LL | | | ||
LL | | pub fn foo() {} | ||
| |_______________^ | ||
| | ||
note: the lint level is defined here | ||
--> $DIR/check.rs:4:9 | ||
| | ||
LL | #![warn(missing_docs)] | ||
| ^^^^^^^^^^^^ | ||
|
||
warning: missing documentation for a function | ||
--> $DIR/check.rs:9:1 | ||
| | ||
LL | pub fn foo() {} | ||
| ^^^^^^^^^^^^ | ||
|
||
warning: missing code example in this documentation | ||
--> $DIR/check.rs:4:1 | ||
| | ||
LL | / #![warn(missing_docs)] | ||
LL | | | ||
LL | | | ||
LL | | #![warn(rustdoc)] | ||
LL | | | ||
LL | | pub fn foo() {} | ||
| |_______________^ | ||
| | ||
note: the lint level is defined here | ||
--> $DIR/check.rs:7:9 | ||
| | ||
LL | #![warn(rustdoc)] | ||
| ^^^^^^^ | ||
= note: `#[warn(missing_doc_code_examples)]` implied by `#[warn(rustdoc)]` | ||
|
||
warning: missing code example in this documentation | ||
--> $DIR/check.rs:9:1 | ||
| | ||
LL | pub fn foo() {} | ||
| ^^^^^^^^^^^^^^^ | ||
|
||
warning: 4 warnings emitted | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
// compile-flags: -Z unstable-options --check | ||
|
||
// @!has check/fn.foo.html | ||
// @!has check/index.html | ||
pub fn foo() {} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.