Skip to content

Allow linking against crates with #[no_std] #7874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/librustc/metadata/encoder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1460,6 +1460,9 @@ fn encode_lang_items(ecx: &EncodeContext, ebml_w: &mut writer::Encoder) {
ebml_w.start_tag(tag_lang_items);

for ecx.tcx.lang_items.each_item |def_id, i| {
let def_id = match def_id {
Some(id) => id, None => { loop }
};
if def_id.crate != local_crate {
loop;
}
Expand Down
4 changes: 2 additions & 2 deletions src/librustc/middle/lang_items.rs
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ impl LanguageItems {
}
}

pub fn each_item(&self, f: &fn(def_id: def_id, i: uint) -> bool) -> bool {
self.items.iter().enumerate().advance(|(i, &item)| f(item.get(), i))
pub fn each_item(&self, f: &fn(Option<def_id>, uint) -> bool) -> bool {
self.items.iter().enumerate().advance(|(i, &item)| f(item, i))
}

pub fn item_name(index: uint) -> &'static str {
Expand Down
2 changes: 1 addition & 1 deletion src/rt/rust_crate_map.h
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class cratemap {
return &reinterpret_cast<const cratemap_v0 *>(this)->
m_children[0];
case 1:
return &m_children[1];
return &m_children[0];
default: assert(false && "Unknown crate map version!");
return NULL; // Appease -Werror=return-type
}
Expand Down
3 changes: 3 additions & 0 deletions src/test/auxiliary/no_std_crate.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#[no_std];

pub fn foo() {}
21 changes: 21 additions & 0 deletions src/test/run-pass/no-std-xcrate.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast
// aux-build:no_std_crate.rs

// This tests that crates which link to std can also be linked to crates with
// #[no_std] that have no lang items.

extern mod no_std_crate;

fn main() {
no_std_crate::foo();
}
33 changes: 33 additions & 0 deletions src/test/run-pass/no-std-xcrate2.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
// Copyright 2013 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// xfail-fast
// aux-build:no_std_crate.rs

// This tests that libraries built with #[no_std] can be linked to crates with
// #[no_std] and actually run.

#[no_std];

extern mod no_std_crate;

// This is an unfortunate thing to have to do on linux :(
#[cfg(target_os = "linux")]
#[doc(hidden)]
pub mod linkhack {
#[link_args="-lrustrt -lrt"]
extern {}
}

#[start]
fn main(_: int, _: **u8, _: *u8) -> int {
no_std_crate::foo();
0
}