-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Reducing spurious unused lifetime warnings. #64603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
// edition:2018 | ||
|
||
// Avoid spurious warnings of unused lifetime. The below async functions | ||
// are desugered to have an unused lifetime | ||
// but we don't want to warn about that as there's nothing they can do about it. | ||
|
||
#![deny(unused_lifetimes)] | ||
#![allow(dead_code)] | ||
|
||
pub async fn october(s: &str) { | ||
println!("{}", s); | ||
} | ||
|
||
pub async fn async_fn(&mut ref s: &mut[i32]) { | ||
println!("{:?}", s); | ||
} | ||
|
||
macro_rules! foo_macro { | ||
() => { | ||
pub async fn async_fn_in_macro(&mut ref _s: &mut[i32]) {} | ||
}; | ||
} | ||
|
||
foo_macro!(); | ||
|
||
pub async fn func_with_unused_lifetime<'a>(s: &'a str) { | ||
//~^ ERROR lifetime parameter `'a` never used | ||
println!("{}", s); | ||
} | ||
|
||
pub async fn func_with_two_unused_lifetime<'a, 'b>(s: &'a str, t: &'b str) { | ||
//~^ ERROR lifetime parameter `'a` never used | ||
//~^^ ERROR lifetime parameter `'b` never used | ||
println!("{}", s); | ||
} | ||
|
||
pub async fn func_with_unused_lifetime_in_two_params<'c>(s: &'c str, t: &'c str) { | ||
//~^ ERROR lifetime parameter `'c` never used | ||
println!("{}", s); | ||
} | ||
|
||
fn main() {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
error: lifetime parameter `'a` never used | ||
--> $DIR/unused-lifetime.rs:26:40 | ||
| | ||
LL | pub async fn func_with_unused_lifetime<'a>(s: &'a str) { | ||
| ^^ | ||
| | ||
note: lint level defined here | ||
--> $DIR/unused-lifetime.rs:7:9 | ||
| | ||
LL | #![deny(unused_lifetimes)] | ||
| ^^^^^^^^^^^^^^^^ | ||
|
||
error: lifetime parameter `'a` never used | ||
--> $DIR/unused-lifetime.rs:31:44 | ||
| | ||
LL | pub async fn func_with_two_unused_lifetime<'a, 'b>(s: &'a str, t: &'b str) { | ||
| ^^ | ||
|
||
error: lifetime parameter `'b` never used | ||
--> $DIR/unused-lifetime.rs:31:48 | ||
| | ||
LL | pub async fn func_with_two_unused_lifetime<'a, 'b>(s: &'a str, t: &'b str) { | ||
| ^^ | ||
|
||
error: lifetime parameter `'c` never used | ||
--> $DIR/unused-lifetime.rs:37:54 | ||
| | ||
LL | pub async fn func_with_unused_lifetime_in_two_params<'c>(s: &'c str, t: &'c str) { | ||
| ^^ | ||
|
||
error: aborting due to 4 previous errors | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.