Refine the link_args that are propagated #5331
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The one thing `log` can still do is polymorphically log anything,
but debug!, etc. require a format string. With this patch
you can equivalently write `debug!(foo)` or `debug!("%?", foo)`
I missed this when I replaced iter-trait with a `BaseIter` impl.
r?
`log` can polymorphically log anything, but debug!, etc. requires a format string. With this patch you can equivalently write `debug!(foo)` or `debug!("%?", foo)`.
I'm doing this because I was trying to remove `log` (replacing it with nothing, at least temporarily), but there are a number of logging statements that just want to print an arbitrary value and don't care about the format string.
I'm not entirely convinced this is a good change, since it overloads the implementation of these macros and makes their usage slightly more nuanced.
Without this change, rust-mode doesn't work if 'cl hasn't been required by something else, apparently. I'm not entirely sure what changed such that I started seeing this problem instead of not, but maybe the emacs world has been making progress towards not loading 'cl at runtime if it's only needed at compile time.
This makes `#[deriving_clone]` useful. I wasn't sure if a macro was the right way to do this, but it seems more maintainable than a series of repetitive `impl`s.
* add 'self region to the borrowed pointer parameter * rm workaround for rust-lang#2263 * inline (wrappers) * iter-trait is gone
Two small changes: `Not` was missing from the list of core traits and `assert` was removed from the language.
Modify pretty-printer to emit lifetimes and fix a few minor parser bugs that this uncovered.
…ifetimes-2, r=nikomatsakis Modify pretty-printer to emit lifetimes and fix a few minor parser bugs that this uncovered. r? whomever.
Without this change, rust-mode doesn't work if 'cl hasn't been required by something else, apparently. I'm not entirely sure what changed such that I started seeing this problem instead of not, but maybe the emacs world has been making progress towards not loading 'cl at runtime if it's only needed at compile time. (This change was previously submitted as e93a58d and accidentally reverted by ad8b437.)
…=nikomatsakis Simplify the interface to check_fn by pulling some of the madness out to its callers. rs=refactor
There were three issues effecting the example in the getopts rustdoc: 1. The blockquote was incorrectly formatted. Fixed by switching to using an explicit markdown code section with ```. 2. The `fail fail_str(f)` would not compile. Fixed by using `fail!()` instead of `fail`. 3. The line `matches.free[0]` produced a compile error about moving from an immutable vector. Fix by using `copy`.
Previous year range of 2011-2013 was based on file creation date. The check_license python script, however, only accepts copyrights starting in 2012 or later.
…x, r=luqmana There were three issues effecting the example in the getopts rustdoc: 1. The blockquote was incorrectly formatted. Fixed by switching to using an explicit markdown code section with ```. 2. The `fail fail_str(f)` would not compile. Fixed by using `fail!()` instead of `fail`. 3. The line `matches.free[0]` produced a compile error about moving from an immutable vector. Fix by using `copy`.
Out goes the extra layer of struct wrapping; the destructedness flag is added to the end of the struct. This means that, if the struct previously had alignment padding at the end, the flag will live there instead of increasing the struct size.
The only thing we really lose is that C-like enums with one variant and a non-zero discriminant now take up space, but I do not think this is a common usage. As previously noted, that was mostly there for transitional compatibility with the pre-adt.rs codebase.
Struct and enum representations have some complicatedness that's no longer needed. Now that everything's in one place and has access to anything we'd want to know about the type, flatten some of that out. Slight changes to representations in some cases.
r? Like `buf_as_slice` but for mutable pointers and slices.
r? Followup to rust-lang#5022. This is the same, but everything is in `core::rt` now. `std::uv_ll` is moved to `core::unstable::uvll`, with the intent that it eventually move into its own crate (blocked on rust-lang#5192 at least). I've had to disable the uv tests because of rust-lang#2064. All of `core::rt` is disabled on platforms that aren't mac or linux until I complete the windows thread local storage bindings and ARM context switching. My immediate next priorities will be to fix rust-lang#2064 and clean up the uv bindings, get everything building on all platforms.
… under arbitrary directories.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
clean up a few lint docs changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original change bit Servo because rust-harfbuzz includes libharfbuzz.a in its link_args. This works fine in the rust-harfbuzz subdirectory where the static library resides, but when this is propagated to servo_gfx, the lirbrary can no longer be found since it's a relative path.