Skip to content

[chalkify] Small refactoring and WF/FromEnv rules for types #51433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 22, 2018
Merged

[chalkify] Small refactoring and WF/FromEnv rules for types #51433

merged 4 commits into from
Jun 22, 2018

Conversation

scalexm
Copy link
Member

@scalexm scalexm commented Jun 8, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 8, 2018
@pietroalbini
Copy link
Member

Ping from triage @nikomatsakis! This PR needs your review.

@nikomatsakis
Copy link
Contributor

@bors r+

@pietroalbini
Copy link
Member

@bors r=nikomatsakis

@bors
Copy link
Collaborator

bors commented Jun 20, 2018

📌 Commit 796ded2 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2018
@bors
Copy link
Collaborator

bors commented Jun 21, 2018

⌛ Testing commit 796ded2 with merge 35783f283b4571153f7a8707206c5772a96b676d...

@bors
Copy link
Collaborator

bors commented Jun 21, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 21, 2018
@rust-highfive
Copy link
Contributor

The job dist-x86_64-linux-alt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[01:11:28] [TIMING] Analysis { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } -- 2.988
[01:11:28] Dist src
[01:11:40] [TIMING] Src -- 12.744
[01:11:40] Create plain source tarball
[01:13:37] curl: (6) Couldn't resolve host 's3-us-west-1.amazonaws.com'
[01:15:29] curl: (6) Couldn't resolve host 's3-us-west-1.amazonaws.com'
[01:17:22] curl: (6) Couldn't resolve host 's3-us-west-1.amazonaws.com'
[01:17:22] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:575:17
[01:17:22] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu
[01:17:22] Build completed unsuccessfully in 1:11:19
travis_time:end:04bfa000:start=1529561613057339809,finish=1529566255330042980,duration=4642272703171

---
travis_time:end:210079ce:start=1529566256794353871,finish=1529566256801874250,duration=7520379
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0b4e0685
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
global:
global:
  _ZdaPv;
  _ZdaPvRKSt9nothrow_t;
  _ZdaPvSt11align_val_t;
  _ZdaPvSt11align_val_tRKSt9nothrow_t;
  _ZdaPvj;
  _ZdaPvjSt11align_val_t;
  _ZdlPv;
  _ZdlPvRKSt9nothrow_t;
  _ZdlPvSt11align_val_t;
  _ZdlPvSt11align_val_tRKSt9nothrow_t;
  _ZdlPvj;
  _ZdlPvjSt11align_val_t;
  _Znaj;
  _ZnajRKSt9nothrow_t;
  _ZnajSt11align_val_t;
  _ZnajSt11align_val_tRKSt9nothrow_t;
  _Znwj;
  _ZnwjRKSt9nothrow_t;
  _ZnwjSt11align_val_t;
  _ZnwjSt11align_val_tRKSt9nothrow_t;
  __asan_*;
  __cxa_atexit;
  __cxa_throw;
  __fprintf_chk;
  __getdelim;
  __interceptor___cxa_atexit;
  __interceptor___cxa_throw;
  __interceptor___fprintf_chk;
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:247b1c44
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive
Copy link
Contributor

The job dist-x86_64-linux-alt of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[01:11:28] [TIMING] Analysis { compiler: Compiler { stage: 2, host: "x86_64-unknown-linux-gnu" }, target: "x86_64-unknown-linux-gnu" } -- 2.988
[01:11:28] Dist src
[01:11:40] [TIMING] Src -- 12.744
[01:11:40] Create plain source tarball
[01:13:37] curl: (6) Couldn't resolve host 's3-us-west-1.amazonaws.com'
[01:15:29] curl: (6) Couldn't resolve host 's3-us-west-1.amazonaws.com'
[01:17:22] curl: (6) Couldn't resolve host 's3-us-west-1.amazonaws.com'
[01:17:22] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:575:17
[01:17:22] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu
[01:17:22] Build completed unsuccessfully in 1:11:19
travis_time:end:04bfa000:start=1529561613057339809,finish=1529566255330042980,duration=4642272703171

---
travis_time:end:210079ce:start=1529566256794353871,finish=1529566256801874250,duration=7520379
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0b4e0685
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
global:
global:
  _ZdaPv;
  _ZdaPvRKSt9nothrow_t;
  _ZdaPvSt11align_val_t;
  _ZdaPvSt11align_val_tRKSt9nothrow_t;
  _ZdaPvj;
  _ZdaPvjSt11align_val_t;
  _ZdlPv;
  _ZdlPvRKSt9nothrow_t;
  _ZdlPvSt11align_val_t;
  _ZdlPvSt11align_val_tRKSt9nothrow_t;
  _ZdlPvj;
  _ZdlPvjSt11align_val_t;
  _Znaj;
  _ZnajRKSt9nothrow_t;
  _ZnajSt11align_val_t;
  _ZnajSt11align_val_tRKSt9nothrow_t;
  _Znwj;
  _ZnwjRKSt9nothrow_t;
  _ZnwjSt11align_val_t;
  _ZnwjSt11align_val_tRKSt9nothrow_t;
  __asan_*;
  __cxa_atexit;
  __cxa_throw;
  __fprintf_chk;
  __getdelim;
  __interceptor___cxa_atexit;
  __interceptor___cxa_throw;
  __interceptor___fprintf_chk;
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:247b1c44
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Jun 21, 2018

@bors retry travis-ci/travis-ci#9696

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2018
@bors
Copy link
Collaborator

bors commented Jun 22, 2018

⌛ Testing commit 796ded2 with merge 0b8d817...

bors added a commit that referenced this pull request Jun 22, 2018
@bors
Auto merge of #51433 - scalexm:finish-rules, r=nikomatsakis
0b8d817 
[chalkify] Small refactoring and WF/FromEnv rules for types

r? @nikomatsakis
@bors
Copy link
Collaborator

bors commented Jun 22, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 0b8d817 to master...

@bors bors merged commit 796ded2 into rust-lang:master Jun 22, 2018
@bors bors mentioned this pull request Jun 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@scalexm @pietroalbini @nikomatsakis @bors @rust-highfive @kennytm