Skip to content

librustc: Make &const [T] mean the same thing as &[const T] #5110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

librustc: Make &const [T] mean the same thing as &[const T] #5110

wants to merge 10 commits into from

Conversation

pcwalton
Copy link
Contributor

r? @brson

bors added a commit that referenced this pull request Feb 26, 2013
@bors
auto merge of #5110 : pcwalton/rust/and-const, r=pcwalton
565ec93 
r? @brson
@bors bors closed this Feb 26, 2013
bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2020
@bors
Auto merge of rust-lang#5110 - Aloso:patch-1, r=flip1995
8e9089e 
Fix syntax highlighting of code fences

The documentation for RESULT_EXPECT_USED includes this code:

    let res: Result<usize, ()> = Ok(1);
    res?;
    # Ok::<(), ()>(())

Because the code fence didn't start with `rust`, the code wasn't highlighted and the line starting with `#` was displayed on the website. This is now fixed.

EDIT: I noticed that highlighting for some other lints is broken as well. It only works if the code fence looks like this:

````markdown
```rust
// ..
```
````

However, many code blocks were ignored. I un-ignored most code blocks and made them compile by adding hidden code with `#`. While doing so, I found two mistakes:

```rust
opt.map_or(None, |a| a + 1)
// instead of
opt.map_or(None, |a| Some(a + 1))
```
and

```rust
fn as_str(self) -> &str
// instead of
fn as_str(self) -> &'static str
```

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcwalton @bors