Skip to content

Update cargo #51062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2018
Merged

Update cargo #51062

merged 1 commit into from
May 27, 2018

Conversation

mati865
Copy link
Member

@mati865 mati865 commented May 25, 2018

There are few nice fixes waiting already.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Contributor

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 25, 2018
@rust-highfive
Copy link
Contributor

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
###########################################################               82.4%
######################################################################## 100.0%
[00:01:13] extracting /checkout/obj/build/cache/2018-05-10/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:13]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:31] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:31] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:31] Build completed unsuccessfully in 0:00:33
[00:01:31] make: *** [prepare] Error 1
[00:01:31] Makefile:81: recipe for target 'prepare' failed
[00:01:32]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:32]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:33] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:33] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:33] Build completed unsuccessfully in 0:00:00
[00:01:33] make: *** [prepare] Error 1
[00:01:33] Makefile:81: recipe for target 'prepare' failed
[00:01:35]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:35]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:36] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:36] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:36] Build completed unsuccessfully in 0:00:00
[00:01:36] Makefile:81: recipe for target 'prepare' failed
[00:01:36] make: *** [prepare] Error 1
[00:01:39]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:39]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:40] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:40] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:40] Build completed unsuccessfully in 0:00:01
[00:01:40] Makefile:81: recipe for target 'prepare' failed
[00:01:40] make: *** [prepare] Error 1
[00:01:44]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:44]     Updating registry `https://github.com/rust-lang/crates.io-index`
[00:01:45] error: the lock file needs to be updated but --locked was passed to prevent this
[00:01:45] failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
[00:01:45] Build completed unsuccessfully in 0:00:00
[00:01:45] Makefile:81: recipe for target 'prepare' failed
[00:01:45] make: *** [prepare] Error 1
[00:01:45] The command has failed after 5 attempts.

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 1.
travis_time:start:01c2a7a3
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@nikomatsakis
Copy link
Contributor

r? @alexcrichton

@alexcrichton
Copy link
Member

r=me, but looks like the lockfile needs an update?

@mati865
Copy link
Member Author

mati865 commented May 25, 2018

I see, I'll update it soon when I get access to my machine.

@ishitatsuyuki
Copy link
Contributor

It seems that you did an cargo update, which updates all dependencies available. That can cause some weird regressions and is more likely to cause a merge conflict.

Instead, please do cd src && cargo clean, which is the way that allows Cargo to update the lockfile conservatively. (clean is a little bit silly here, but it's a hack as there's no "just conservatively update" subcommand implemented)

@mati865
Copy link
Member Author

mati865 commented May 26, 2018

Thank you for the reviews.
Addressed comments and Travis is green, waiting for r.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented May 26, 2018

📌 Commit 9cae4ed has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2018
@bors
Copy link
Collaborator

bors commented May 26, 2018

🔒 Merge conflict

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 26, 2018
@mati865
Copy link
Member Author

mati865 commented May 26, 2018

Rebased.
Guess (and expect) I cannot do it but let's try:

@bors r=alexcrichton

@bors
Copy link
Collaborator

bors commented May 26, 2018

@mati865: 🔑 Insufficient privileges: Not in reviewers

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented May 27, 2018

📌 Commit 05f15d4 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 27, 2018
@kennytm
Copy link
Member

kennytm commented May 27, 2018

@bors p=1

@bors
Copy link
Collaborator

bors commented May 27, 2018

⌛ Testing commit 05f15d4 with merge ad2591c...

bors added a commit that referenced this pull request May 27, 2018
Update cargo

There are few nice fixes waiting already.
@bors
Copy link
Collaborator

bors commented May 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing ad2591c to master...

@bors bors merged commit 05f15d4 into rust-lang:master May 27, 2018
@mati865 mati865 deleted the cargo_update branch May 28, 2018 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants