Skip to content

Update Rustfmt #50261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2018
Merged

Update Rustfmt #50261

merged 1 commit into from
Apr 30, 2018

Conversation

nrc
Copy link
Member

@nrc nrc commented Apr 26, 2018

r? @kennytm

Updates rustfmt, should fix the broken tests, but I can't reproduce locally, so who knows?

Copy link
Member

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after this Cargo.lock change is reverted or explained.

src/Cargo.lock Outdated
@@ -1561,7 +1561,7 @@ dependencies = [
"lazy_static 1.0.0 (registry+https://github.com/rust-lang/crates.io-index)",
"libc 0.2.40 (registry+https://github.com/rust-lang/crates.io-index)",
"num_cpus 1.8.0 (registry+https://github.com/rust-lang/crates.io-index)",
"rand 0.4.2 (registry+https://github.com/rust-lang/crates.io-index)",
"rand 0.3.22 (registry+https://github.com/rust-lang/crates.io-index)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intended?

@pietroalbini pietroalbini added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 28, 2018
@nrc
Copy link
Member Author

nrc commented Apr 30, 2018

@bors r=kennytm p=10

@bors
Copy link
Collaborator

bors commented Apr 30, 2018

📌 Commit 410e201 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 30, 2018
@bors
Copy link
Collaborator

bors commented Apr 30, 2018

⌛ Testing commit 410e201 with merge f900bcf...

bors added a commit that referenced this pull request Apr 30, 2018
Update Rustfmt

r? @kennytm

Updates rustfmt, should fix the broken tests, but I can't reproduce locally, so who knows?
@bors
Copy link
Collaborator

bors commented Apr 30, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing f900bcf to master...

@bors bors merged commit 410e201 into rust-lang:master Apr 30, 2018
@kennytm
Copy link
Member

kennytm commented Apr 30, 2018

@nrc Looks like rustfmt isn't fixed 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants