Skip to content

Fix broken CSS for book redirect pages #45998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Conversation

ollie27
Copy link
Member

@ollie27 ollie27 commented Nov 15, 2017

rust.css has to be next to the font files so we shouldn't copy it for
only the book redirect pages, instead just use the version that is
already there.

This also removes the duplicate code creating version_info.html.

Fixes: #45974

rust.css has to be next to the font files so we shouldn't copy it for
only the book redirect pages, instead just use the version that is
already there.

This also removes the duplicate code creating version_info.html.
@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 15, 2017
@kennytm
Copy link
Member

kennytm commented Nov 16, 2017

r? @steveklabnik

@steveklabnik
Copy link
Member

@bors: r+

thank you!

@bors
Copy link
Collaborator

bors commented Nov 20, 2017

📌 Commit 9833fd3 has been approved by steveklabnik

bors added a commit that referenced this pull request Nov 20, 2017
Fix broken CSS for book redirect pages

rust.css has to be next to the font files so we shouldn't copy it for
only the book redirect pages, instead just use the version that is
already there.

This also removes the duplicate code creating version_info.html.

Fixes: #45974
@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2017
@bors
Copy link
Collaborator

bors commented Nov 20, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing 26e881d to master...

@bors bors merged commit 9833fd3 into rust-lang:master Nov 20, 2017
@ollie27 ollie27 deleted the doc_book_css branch November 20, 2017 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants