Prefer libproc_macro APIs to libsyntax ones in the quasi-quoter. #45791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
kennytm
added
the
S-waiting-on-review
|
r? @jseyfried |
…ed TokenStream's.
|
Excellent! @bors r+ |
|
📌 Commit fbcc673 has been approved by |
kennytm
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 10, 2017
Prefer libproc_macro APIs to libsyntax ones in the quasi-quoter. The shift to using `proc_macro`'s own APIs in `proc_macro::quote`, both in the implementation of the quasi-quoter and the Rust code it generates to build `TokenStream`s at runtime, greatly reduces the dependency on `libsyntax`, with the generated runtime code being completely free of it. This is a prerequirement for introducing more abstraction/indirection between `proc_macro` and compiler implementation details (mainly those from `libsyntax`), which I want to attempt. cc @alexcrichton @jseyfried @nrc
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shift to using
proc_macro's own APIs inproc_macro::quote, both in the implementation of the quasi-quoter and the Rust code it generates to buildTokenStreams at runtime, greatly reduces the dependency onlibsyntax, with the generated runtime code being completely free of it.This is a prerequirement for introducing more abstraction/indirection between
proc_macroand compiler implementation details (mainly those fromlibsyntax), which I want to attempt.cc @alexcrichton @jseyfried @nrc