Skip to content

Docs: Add trace_macros! to unstable book #44944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2017
Merged

Docs: Add trace_macros! to unstable book #44944

merged 1 commit into from
Oct 1, 2017

Conversation

dbrgn
Copy link
Contributor

@dbrgn dbrgn commented Sep 30, 2017

As TIL'd at Rustfest :)

Note: This is unfortunately untested, since I'm on my laptop battery, and compiling LLVM would probably eat at least 50% of it on my dual core CPU. (Is there a way to build docs without compiling LLVM?)

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @QuietMisdreavus (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.


The `cargo build` output:

```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like travis choked on the "results" block, because code blocks default to being Rust code. make this ```text instead and this should get past that error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and rebased!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Let's see what travis says now.

@QuietMisdreavus
Copy link
Member

Sadly, I don't know of a way to build docs without building the whole compiler - rustdoc just pulls all the compiler libraries from the sysroot instead of loading them individually from a Cargo.toml, so it needs to have all of them available. It also needs the translation parts of rustc (and thus LLVM) so that it can compile doctests, even though you're not using that part of rustdoc for doc generation.

@steveklabnik
Copy link
Member

Sadly, I don't know of a way to build docs without building the whole compiler

Something like the unstable book is just an mdbook book, so you can cd into it and mdbook build. In general you're right though.

@QuietMisdreavus
Copy link
Member

@bors r+ rollup

Thanks so much!

@bors
Copy link
Collaborator

bors commented Sep 30, 2017

📌 Commit eb59952 has been approved by QuietMisdreavus

@bors
Copy link
Collaborator

bors commented Sep 30, 2017

⌛ Testing commit eb59952 with merge afe9320...

bors added a commit that referenced this pull request Sep 30, 2017
Docs: Add trace_macros! to unstable book

As TIL'd at Rustfest :)

Note: This is unfortunately untested, since I'm on my laptop battery, and compiling LLVM would probably eat at least 50% of it on my dual core CPU. (Is there a way to build docs without compiling LLVM?)
@bors
Copy link
Collaborator

bors commented Oct 1, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: QuietMisdreavus
Pushing afe9320 to master...

@bors bors merged commit eb59952 into rust-lang:master Oct 1, 2017
@dbrgn dbrgn deleted the trace-macros-docs branch October 1, 2017 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants