Skip to content

Add PartialEq/Eq impls to proc_macro::{Spacing, Delimiter} #44003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2017

Conversation

LukasKalbertodt
Copy link
Member

I don't see a reason why those two types shouldn't be tested for equality. But I hardly know anything about proc macros, so I'm probably wrong :)

I don't see a reason why those two types shouldn't be tested for equality.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree these ought to be comparable for equality.

@nikomatsakis
Copy link
Contributor

@bors r+

cc @nrc @jseyfried @alexcrichton -- you all are as close to owners of the proc macro stuff as I can think of just now, so probably ought to be aware, but this seems harmless enough.

@bors
Copy link
Collaborator

bors commented Aug 21, 2017

📌 Commit 4ba242b has been approved by nikomatsakis

@bors
Copy link
Collaborator

bors commented Aug 22, 2017

⌛ Testing commit 4ba242b with merge 7e5578d...

bors added a commit that referenced this pull request Aug 22, 2017
Add PartialEq/Eq impls to proc_macro::{Spacing, Delimiter}

I don't see a reason why those two types shouldn't be tested for equality. But I hardly know anything about proc macros, so I'm probably wrong :)
@bors
Copy link
Collaborator

bors commented Aug 22, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 7e5578d to master...

@bors bors merged commit 4ba242b into rust-lang:master Aug 22, 2017
@LukasKalbertodt LukasKalbertodt deleted the patch-1 branch September 18, 2017 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants