librustc: Make vectors no longer implicitly copyable in rustc. #4362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~20% perf win for trans on -O0, with other minor improvements across the board. No effect on -O2.
|
r+ great work. How did you determine which were questionable? |
|
Manual inspection for most of them, then I got tired of it and made the perl script conservatively add them. |
|
cool. r++ :) |
|
Appears to be merged in 53f41f0 so I'm closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @graydon
~20% perf win for trans on -O0, with other minor improvements across the board.
No effect on -O2.
Much of this change was made with a Perl script to make all the copies explicit. The copies that seem questionable are annotated with
/*bad*/.There is a borrowck unsoundness noted with the "Beware!" comment in typeck — there should be a bug on this. It will go away when we de-mode rustc.