Skip to content

librustc: Make unqualified identifier searches terminate at the nearest ... #4345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Jan 4, 2013

...module scope

r? @catamorphism

@Dretch
Copy link
Contributor

Dretch commented Jan 4, 2013

Does this mean that every single module needs to include use core::prelude::*; in its imports?

@catamorphism
Copy link
Contributor

r+ but a commit message explaining the change -- and the reasons for it -- in a little more detail, for posterity, would be nice. Also, do either the reference manual or the tutorial need to be updated as a result of the new name resolution rules?

@pcwalton
Copy link
Contributor Author

pcwalton commented Jan 4, 2013

@Dretch No, it's only a pain for us in rustc. User code doesn't have to write that import.

The reason why rustc bears this pain is that, due to obscure reasons related to the way core injection works and the multistage bootstrapping process, the build will break due to multiple versions of libcore right after we bump the version of core if we let rustc include core automatically.

@catamorphism
Copy link
Contributor

I think my comment may have been off-base, then, but a more descriptive commit message would still help.

@catamorphism
Copy link
Contributor

Merged in 57c5999

@pcwalton pcwalton reopened this Jan 8, 2013
@pcwalton pcwalton closed this Jan 10, 2013
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants