Remove unused code from librustc_errors #43019
Merged
+4
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
aidanhs
added
the
S-waiting-on-review
|
Thanks for the PR @kevinmehall, we'll check in to make sure @nikomatsakis or another reviewer gets to this soon! |
|
@bors r+ |
|
📌 Commit e863d26 has been approved by |
|
🔒 Merge conflict |
kevinmehall
force-pushed
the
cleanup-errors
branch
from
e863d26 to
17bd76a
Compare
|
@nikomatsakis Rebased |
|
@bors r+ |
|
📌 Commit 17bd76a has been approved by |
|
@bors rollup |
bors
added a commit
that referenced
this pull request
Jul 8, 2017
Remove unused code from librustc_errors While extracting librustc_errors into a [reusable library](https://github.com/kevinmehall/codemap-diagnostic), I noticed some obsolete code that the `dead_code` warning missed because it was marked `pub` but not used elsewhere.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While extracting librustc_errors into a reusable library, I noticed some obsolete code that the
dead_codewarning missed because it was markedpubbut not used elsewhere.