Accept ninja-build binary in place of ninja #38627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // OK | ||
| } else { | ||
| need_cmd("ninja".as_ref) | ||
| } |
There was a problem hiding this comment.
Perhaps this could look like:
if !have_cmd("ninja-build".as_ref()) {
need_cmd("ninja".as_ref())
}The comment can just indicate that if ninja-build is present we won't need ninja because CMake detects both.
hanna-kruppe
force-pushed
the
ninja-build
branch
from
534a03d to
d44bcbf
Compare
|
@bors: r+ Thanks! |
|
📌 Commit d44bcbf has been approved by |
|
⌛ Testing commit d44bcbf with merge 3f957eb... |
bors
added a commit
that referenced
this pull request
Dec 29, 2016
Accept ninja-build binary in place of ninja See comment in the diff for rationale. r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See comment in the diff for rationale.
r? @alexcrichton