configure: only req CMake if we're building LLVM #38128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
codyps
reviewed
Dec 2, 2016
| @@ -848,7 +848,10 @@ then | |||
| fi | |||
|
|
|||
| # For building LLVM | |||
| probe_need CFG_CMAKE cmake | |||
| if [ -z $CFG_LLVM_ROOT ] | |||
There was a problem hiding this comment.
Should this be quoted? if [ -z "$CFG_LLVM_ROOT"]?
|
Looks good to me, but I agree that we probably need quotes (or at least I think we do...) |
CMake is only necessary if LLVM is going to be built and not in any other case. Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
cardoe
force-pushed
the
req-cmake-only-for-llvm
branch
from
c7711fc to
e39c8d6
Compare
|
Fixed. I agree it should be quoted. I was actually copying the behavior in other places in the script. I'll add another commit that quotes that. |
These should probably be quoted. Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
|
@bors: r+ |
|
📌 Commit f83eb40 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 6, 2016
configure: only req CMake if we're building LLVM CMake is only necessary if LLVM is going to be built and not in any other case. Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake is only necessary if LLVM is going to be built and not in any
other case.
Signed-off-by: Doug Goldstein cardoe@cardoe.com