Fix terminfo database search path #37469
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| dirs_to_search.push(PathBuf::from(dir)); | ||
| } | ||
|
|
||
| if let Ok(dirs) = match env::var("TERMINFO_DIRS") { |
There was a problem hiding this comment.
match here is an error. You want to if let or match, not both here.
|
📌 Commit f9cc166 has been approved by |
|
⌛ Testing commit f9cc166 with merge 7b96738... |
|
@bors: retry force clean |
Fix terminfo database search path This is more consistent with what every other program does, I happened to have `TERMINFO` set as `/usr/share/terminfo` but had the actual database in `~/.terminfo`, regardless of that every other terminfo/ncurses based software picked up the one in the home correctly. This just puts the path in `TERMINFO` at the top of the search paths, and moves the home checking to the default search paths section.
This is more consistent with what every other program does, I happened to have
TERMINFOset as/usr/share/terminfobut had the actual database in~/.terminfo, regardless of that every other terminfo/ncurses based software picked up the one in the home correctly.This just puts the path in
TERMINFOat the top of the search paths, and moves the home checking to the default search paths section.