Add error code flags #34401
Add error code flags #34401
Conversation
| @@ -947,6 +945,8 @@ position that needs that trait. For example, when the following code is | |||
| compiled: | |||
|
|
|||
| ```compile_fail | |||
| #![feature(on_unimplemented)] | |||
|
|
|||
There was a problem hiding this comment.
Why did these examples start requiring #![feature(on_unimplemented)] but still not get error code annotations?
There was a problem hiding this comment.
Because in order to use #[rustc_on_unimplemented], you need to enable the feature. However, the code throws E0230, so I can't add E0272. The same goes for E0273 and E0274.
|
@bors r+ |
|
📌 Commit 8f987ab has been approved by |
Add error code flags r? @brson cc @steveklabnik cc @jonathandturner
| // nothing here | ||
| ```compile_fail,E0269 | ||
| fn abracada_FAIL() -> String { | ||
| "this won't work".to_string(); |
There was a problem hiding this comment.
Is this change intentional?
It seems the source code does not match the following explanation text anymore.
There was a problem hiding this comment.
Ah damn, i didn't pay attention to the explanation. Want to fix it?
There was a problem hiding this comment.
Sorry, it don't have enough time/knowledge to fix this in short time frame.
There was a problem hiding this comment.
I'll then. Thanks for notifying me!
r? @brson
cc @steveklabnik
cc @jonathandturner