Document CStr::as_ptr dangers.
#34356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
force-pushed
the
cstr-docs
branch
2 times, most recently
from
dbd543e to
9ed36d7
Compare
|
Nice explanation, I approve! Thanks! @bors: r+ rollup |
|
📌 Commit 9ed36d7 has been approved by |
|
Oups, didn't know that |
|
Ah right, didn't pay attention. @bors: r+ rollup |
|
📌 Commit 677aa47 has been approved by |
|
⌛ Testing commit 677aa47 with merge 33aa3ed... |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 20, 2016
Document `CStr::as_ptr` dangers. r? @steveklabnik Hi! I've tried to document `CString::new("hello").unwrap().as_ptr()` footgun. Related [RFC] and the original [discussion]. [RFC]: rust-lang/rfcs#1642 [discussion]: https://users.rust-lang.org/t/you-should-stop-telling-people-that-safe-rust-is-always-safe/6094
|
⛄ The build was interrupted to prioritize another pull request. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 21, 2016
Document `CStr::as_ptr` dangers. r? @steveklabnik Hi! I've tried to document `CString::new("hello").unwrap().as_ptr()` footgun. Related [RFC] and the original [discussion]. [RFC]: rust-lang/rfcs#1642 [discussion]: https://users.rust-lang.org/t/you-should-stop-telling-people-that-safe-rust-is-always-safe/6094
bors
added a commit
that referenced
this pull request
Jun 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @steveklabnik
Hi! I've tried to document
CString::new("hello").unwrap().as_ptr()footgun. Related RFC and the original discussion.