Reflect supporting only LLVM 3.7+ in the LLVM wrappers #34178
Conversation
| @@ -34,13 +31,8 @@ struct LLVMRustArchiveMember { | |||
| ~LLVMRustArchiveMember() {} | |||
| }; | |||
|
|
|||
| #if LLVM_VERSION_MINOR >= 6 | |||
| typedef OwningBinary<Archive> RustArchive; | |||
| #define GET_ARCHIVE(a) ((a)->getBinary()) | |||
There was a problem hiding this comment.
Uses of GET_ARCHIVE can be inlined now?
|
Seems overall good to me, but I would rather get alex to sign off on it. |
|
Yeah, reading through the nested conditionals is pretty mind-bending; I had to redo a handful of the sections a few times! The more 👀 the better! |
| #endif | ||
| unwrap(PMB)->SLPVectorize = SLPVectorize; | ||
| unwrap(PMB)->OptLevel = OptLevel; | ||
| unwrap(PMB)->LoopVectorize = LoopVectorize; |
There was a problem hiding this comment.
Maybe these were accidentally deleted?
There was a problem hiding this comment.
Ooops, nice catch! Fixed now.
|
Awesome, thanks @shepmaster! If you're feeling extra ambitious we can now probably also remove the long-dead code path of actually calling That can also be saved for another PR, however, as there's probably even more cleanup that could happen in that module. |
shepmaster
force-pushed
the
llvm-3.7-and-up
branch
from
231b9ca to
f3d9de4
Compare
I'd be happy to submit a separate PR for that, but I'm not seeing where the big cleanup would be there. It looks like that function can still return |
|
What a relief to jettison all that cruft. |
Based on 12abddb, it appears we can drop support for these older LLVM versions. Hopefully, this will make it slightly easier to support the changes needed for LLVM 3.9.
r? @nagisa
/cc @brson