Skip to content

cover more linux targets in libstd cargobuild #32132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2016

Conversation

arcnmx
Copy link
Contributor

@arcnmx arcnmx commented Mar 8, 2016

libstd/build.rs checked the target name against "unknown-linux"... That doesn't necessarily apply to all Linux targets as some toolchains for embedded targets will change that unknown field to some vendor name. Some shifting around was needed since Android is also a Linux target.

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+ dbe2389

Thanks!

@alexcrichton alexcrichton self-assigned this Mar 8, 2016
@bors
Copy link
Collaborator

bors commented Mar 11, 2016

⌛ Testing commit dbe2389 with merge aef46ac...

@bors
Copy link
Collaborator

bors commented Mar 11, 2016

💔 Test failed - auto-mac-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Fri, Mar 11, 2016 at 1:38 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-mac-64-opt
http://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/8332


Reply to this email directly or view it on GitHub
#32132 (comment).

@bors
Copy link
Collaborator

bors commented Mar 11, 2016

⌛ Testing commit dbe2389 with merge 0d68aad...

bors added a commit that referenced this pull request Mar 11, 2016
cover more linux targets in libstd cargobuild

libstd/build.rs checked the target name against `"unknown-linux"`... That doesn't necessarily apply to all Linux targets as some toolchains for embedded targets will change that `unknown` field to some vendor name. Some shifting around was needed since Android is also a Linux target.

r? @alexcrichton
@bors bors merged commit dbe2389 into rust-lang:master Mar 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants